refactor: use @namada/sdk package in the extension #2288
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateuszjasiuk
force-pushed
the
feat/use-namada-sdkjs-in-extension
branch
2 times, most recently
from
c8c4baf to
4a4ed2b
Compare
jurevans
reviewed
Aug 21, 2025
|
|
||
| // SDK wasm init must be called | ||
| await initWasm(); | ||
| // We only do this to initialize wasm, props don't matter |
There was a problem hiding this comment.
Just a note, though I think this is fine: There is an init that is directly exported (same with */inline) that doesn't initialize Sdk, but since we don't use the inline imports in extension, you'd have to pass the wasm as an arg :D Maybe that can be improved in the future, but let's keep it like this for now!
mateuszjasiuk
force-pushed
the
feat/use-namada-sdkjs-in-extension
branch
from
5261d8d to
1be9ce3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.